feat!: update the return value for n=1 in math/base/special/bernoulli
#3108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
reviewed
Nov 13, 2024
lib/node_modules/@stdlib/math/base/special/bernoulli/benchmark/c/native/benchmark.c
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Nov 13, 2024
lib/node_modules/@stdlib/math/base/special/bernoulli/src/main.c
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Nov 13, 2024
lib/node_modules/@stdlib/math/base/special/bernoulli/test/test.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Nov 13, 2024
lib/node_modules/@stdlib/math/base/special/bernoulli/test/test.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Nov 13, 2024
lib/node_modules/@stdlib/math/base/special/bernoulli/test/test.native.js
Outdated
Show resolved
Hide resolved
kgryte
changed the title
n=1 in math/base/special/bernoullin=1 in math/base/special/bernoulli
|
Note that this change is not a "refactor", per se, but a breaking change. Upon merging, we will need to articulate that breaking change to ensure that the changelog is populated correctly. |
kgryte
added
the
Needs Changes
1 task
…/c/native/benchmark.c Co-authored-by: Athan <[email protected]> Signed-off-by: Gunj Joshi <[email protected]>
Co-authored-by: Athan <[email protected]> Signed-off-by: Gunj Joshi <[email protected]>
….native.js Co-authored-by: Athan <[email protected]> Signed-off-by: Gunj Joshi <[email protected]>
Co-authored-by: Athan <[email protected]> Signed-off-by: Gunj Joshi <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>
Got it, thanks for explaining! |
kgryte
reviewed
Nov 14, 2024
lib/node_modules/@stdlib/math/base/special/bernoulli/test/test.native.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
kgryte
removed
the
Needs Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
math/base/special/bernoullif#3037 (comment)n = 1, and return0.5inmath/base/special/bernoulli.Related Issues
None.
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers